Messages in this thread Patch in this message | | | From | Amos Kong <> | Subject | [PATCH v5 REPOST 5/6] hw_random: don't double-check old_rng. | Date | Mon, 8 Dec 2014 16:50:39 +0800 |
| |
From: Rusty Russell <rusty@rustcorp.com.au>
Interesting anti-pattern.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- drivers/char/hw_random/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index 067270b..a9286bf 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers/char/hw_random/core.c @@ -476,14 +476,13 @@ int hwrng_register(struct hwrng *rng) } old_rng = current_rng; + err = 0; if (!old_rng) { err = hwrng_init(rng); if (err) goto out_unlock; set_current_rng(rng); - } - err = 0; - if (!old_rng) { + err = register_miscdev(); if (err) { drop_current_rng(); -- 1.9.3
| |