lkml.org 
[lkml]   [2014]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec
    From
    Hi,

    On Thu, Dec 4, 2014 at 11:03 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
    >
    >> > New binding should have the "-ns" suffix, right? So, I'd vote to add the
    >> > suffix to the new bindings and deprecate the ones used in the designware
    >> > driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns"
    >> >
    >> > It might be a little more work now, but it will help us in the future,
    >> > because it is the correct way to do it.
    >>
    >> OK, that sounds fair. You're OK with my proposal otherwise?
    >
    > Yes.

    OK, for simplicity I put my requested changes in
    <https://chromium-review.googlesource.com/#/c/232774/3>


    >> Are you looking for Addy or me to submit a patch supporting the "-ns"
    >> suffix on the Designware i2c driver, or should we just use the "-ns"
    >> suffix in the Rockchip driver and assume someone will later add
    >> support for the new binding in the Designware i2c driver?
    >
    > I'd be really happy if you can do it. I'd love to have consistency right
    > away.

    Well that was easy. https://patchwork.kernel.org/patch/5445231/

    -Doug


    \
     
     \ /
      Last update: 2014-12-05 21:01    [W:2.996 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site