Messages in this thread | | | Date | Fri, 5 Dec 2014 13:30:53 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 6/8] perf buildid cache: Fix -a segfault |
| |
Em Mon, Dec 01, 2014 at 08:06:27PM +0100, Jiri Olsa escreveu: > The kcore_filename is uninitialized and trash value could > trigger build_id_cache__add_kcore function ending up with > segfault.
Applied
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> > Cc: David Ahern <dsahern@gmail.com> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Stephane Eranian <eranian@google.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/perf/builtin-buildid-cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c > index 184955ec8a83..7a3504a1b494 100644 > --- a/tools/perf/builtin-buildid-cache.c > +++ b/tools/perf/builtin-buildid-cache.c > @@ -737,7 +737,7 @@ int cmd_buildid_cache(int argc, const char **argv, > *remove_name_list_str = NULL, > *missing_filename = NULL, > *update_name_list_str = NULL, > - *kcore_filename; > + *kcore_filename = NULL; > char sbuf[STRERR_BUFSIZE]; > > struct perf_data_file file = { > -- > 1.9.3
| |