lkml.org 
[lkml]   [2014]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: kernel: fixed style warnings in acct.c
Joshua,

On Fri, Dec 05, 2014 at 01:47:34PM +0900, Joshua I. James wrote:
> From: "Joshua I. James" <joshua@cybercrimetech.com>
>
> Fixed style errors identified by checkpatch.
>
> Output of checkpatch:
> WARNING: Missing a blank line after declarations
> WARNING: line over 80 characters
> ERROR: spaces required around that '==' (ctx:VxV)
> +#if ACCT_VERSION==2
>

It looks like your patch is making three types of changes. A single
patch should make a single type of change. For example, you might fix
all the "blank line after declaration" warnings in one patch.

Doing this helps make your patches easier to review, and if a problem
arises later, easier to bisect.

> Signed-off-by: Joshua I. James <joshua@cybercrimetech.com>
> ---
> kernel/acct.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/acct.c b/kernel/acct.c
> index 33738ef..322159c 100644
> --- a/kernel/acct.c
[...]

It also looks like you only sent this to the linux-kernel mailing list.
You should use scripts/get_maintainer.pl to find who to send it to.

Hope that helps :-)

--
- Jeremiah Mahler


\
 
 \ /
  Last update: 2014-12-05 12:41    [W:0.043 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site