Messages in this thread | | | From | Dan Streetman <> | Date | Thu, 4 Dec 2014 22:27:06 -0500 | Subject | Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64 |
| |
On Thu, Dec 4, 2014 at 4:27 PM, Ashutosh Dixit <ashutosh.dixit@intel.com> wrote: > mic/mpssd along with MIC drivers are currently only usable on > x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on > big-endian systems.
Only building for x86_64 is fine, but in that case what's the point of leaving the htole16() et. al. functions in mpssd.c? Shouldn't they be removed?
> > Reported-by: Daniel Borkmann <dborkman@redhat.com> > Reported-by: Dan Streetman <ddstreet@gmail.com> > Suggested-by: Peter Foley <pefoley2@pefoley.com> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > --- > Documentation/mic/mpssd/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/mic/mpssd/Makefile b/Documentation/mic/mpssd/Makefile > index 0f31568..f47fe6b 100644 > --- a/Documentation/mic/mpssd/Makefile > +++ b/Documentation/mic/mpssd/Makefile > @@ -1,5 +1,5 @@ > # List of programs to build > -hostprogs-y := mpssd > +hostprogs-$(CONFIG_X86_64) := mpssd > > mpssd-objs := mpssd.o sysfs.o > > -- > 2.0.0.rc3.2.g998f840 >
| |