Messages in this thread | | | Subject | Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() | From | Joe Perches <> | Date | Thu, 04 Dec 2014 14:45:01 -0800 |
| |
On Thu, 2014-12-04 at 23:27 +0100, SF Markus Elfring wrote: > >> diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c > > [] > >> @@ -172,9 +172,8 @@ static void mppe_rekey(struct ppp_mppe_state * state, int initial_key) > >> setup_sg(sg_in, state->sha1_digest, state->keylen); > >> setup_sg(sg_out, state->session_key, state->keylen); > >> if (crypto_blkcipher_encrypt(&desc, sg_out, sg_in, > >> - state->keylen) != 0) { > >> - printk(KERN_WARNING "mppe_rekey: cipher_encrypt failed\n"); > >> - } > >> + state->keylen) != 0) > >> + pr_warn("mppe_rekey: cipher_encrypt failed\n"); > > > > It's generally nicer to replace embedded function names > > with "%s: ", __func__ > > > > pr_warn("%s: cipher_encrypt failed\n", __func__); > > Do you want that I send a third patch series for the fine-tuning of these parameters?
If you want.
I just wanted you to be aware of it for future patches.
| |