Messages in this thread | | | Date | Fri, 5 Dec 2014 10:10:23 +0800 | From | Lai Jiangshan <> | Subject | Re: [PATCH wq/for-3.19] workqueue: cosmetic update in rescuer_thread() |
| |
On 12/04/2014 11:14 PM, Tejun Heo wrote: > rescuer_thread() caches &rescuer->scheduled in a local variable > scheduled for convenience. There's one WARN_ON_ONCE() which was using > &rescuer->scheduled directly. Replace it with the local variable. > > This patch causes no functional difference. > > Signed-off-by: Tejun Heo <tj@kernel.org> > ---
Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> Applying to wq/for-3.19. > > Thanks. > > kernel/workqueue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -2246,7 +2246,7 @@ repeat: > * Slurp in all works issued via this workqueue and > * process'em. > */ > - WARN_ON_ONCE(!list_empty(&rescuer->scheduled)); > + WARN_ON_ONCE(!list_empty(scheduled)); > list_for_each_entry_safe(work, n, &pool->worklist, entry) > if (get_work_pwq(work) == pwq) > move_linked_works(work, scheduled, &n); >
| |