lkml.org 
[lkml]   [2014]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] sched/fair: fix find_idlest_cpu return -1
Date


> -----Original Message-----
> From: Vincent Guittot [mailto:vincent.guittot@linaro.org]
> Sent: Thursday, December 04, 2014 8:15 PM
> To: Zhang, Jun
> Cc: mingo@redhat.com; Peter Zijlstra; gregkh@linuxfoundation.org; Hillf
> Danton; linux-kernel; stable@vger.kernel.org; Liu, Chuansheng; Liu,
> Changcheng
> Subject: Re: [PATCH v2] sched/fair: fix find_idlest_cpu return -1
>
> On 4 December 2014 at 12:43, <jun.zhang@intel.com> wrote:
> > From: zhang jun <jun.zhang@intel.com>
> >
> > in function select_task_rq_fair, when find_idlest_cpu return -1 and sd->child
> == NULL
> > select_task_rq_fair return -1, system panic.
>
> you forgot to add on which kernel version this patch applies.
>
> We don't have such issue on 3.18-rc7 as find_idlest_cpu don't return
> -1. We only need a cleanup of the test against -1 for 3.18-rc
>
Agreed, so Jun can make two patches:
The first one patch is in find_idlest_cpu() to not return -1 and based on stable-branch such as 3.14.x;
The second patch is one cleanup for new_cpu == -1 judgment against the 3.18-rc, since it is no possibility now;

Best Regards
Chuansheng



\
 
 \ /
  Last update: 2014-12-05 03:41    [W:0.035 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site