lkml.org 
[lkml]   [2014]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/02] ARM: shmobile: marzen-reference: Remove IRLM workaround
From
Hi Simon,

On Thu, Dec 4, 2014 at 4:21 PM, Simon Horman <horms@verge.net.au> wrote:
> Hi Magnus,
>
> On Wed, Dec 03, 2014 at 09:18:13PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm+renesas@opensource.se>
>>
>> Adjust the r8a7779 SoC DTS and the Marzen Reference
>> C board code to use DTS only for INTC-IRQPIN IRLM setup.
>>
>> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>> ---
>>
>> Written on top of renesas-devel-20141202-v3.18-rc7 and
>> [PATCH] ARM: shmobile: r8a7779 CCF DTS update
>>
>> Has a runtime dependency on:
>> [PATCH 01/02] irqchip: renesas-intc-irqpin: r8a7779 IRLM setup support
>>
>> arch/arm/boot/dts/r8a7779.dtsi | 5 +++--
>> arch/arm/mach-shmobile/board-marzen-reference.c | 7 -------
>> 2 files changed, 3 insertions(+), 9 deletions(-)
>>
>> --- 0002/arch/arm/boot/dts/r8a7779.dtsi
>> +++ work/arch/arm/boot/dts/r8a7779.dtsi 2014-12-03 20:27:49.000000000 +0900
>> @@ -139,7 +139,7 @@
>> interrupt-controller;
>> };
>>
>> - irqpin0: irqpin@fe780010 {
>> + irqpin0: irqpin@fe780000 {
>> compatible = "renesas,intc-irqpin-r8a7779", "renesas,intc-irqpin";
>> #interrupt-cells = <2>;
>> status = "disabled";
>> @@ -148,7 +148,8 @@
>> <0xfe780010 4>,
>> <0xfe780024 4>,
>> <0xfe780044 4>,
>> - <0xfe780064 4>;
>> + <0xfe780064 4>,
>> + <0xfe780000 4>;
>
> Is there any order implied by the above list?
> Naïvely I would expect it to be sorted numerically.

Yes, the driver assumes the register banks to be passed in a certain
order. In the case of r8a7779 we add one more register bank at the end
for IRLM setup. Register detail (base address, access size, order and
bitfield width) varies with SoC version. So the IRLM register will be
at different addresses depending on SoC, but the driver wants it at
the end of the list.

Cheers,

/ magnus


\
 
 \ /
  Last update: 2014-12-04 09:01    [W:0.053 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site