lkml.org 
[lkml]   [2014]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [lm-sensors] [PATCH 1/2] hwmon: tmp401: add support for TI TMP435
On Thu, Dec 04, 2014 at 06:32:28PM +0100, Jean Delvare wrote:
> On Thu, 4 Dec 2014 15:33:47 +0100, Bartosz Golaszewski wrote:
> > 2014-12-04 15:19 GMT+01:00 Guenter Roeck <linux@roeck-us.net>:
> > > The datasheet claims otherwise (0x31, specifically).
> > > Is this based on real chip information ?
> > > Can you send me the output from i2cdump for the chip ?
> > >
> >
> > This is what I'm reading:
> >
> > # i2cdump -y 1 0x4c
> > No size specified (using byte-data access)
> > 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef
> > 00: 1a 1b 00 00 05 55 00 55 00 00 05 55 00 55 00 0d ??..?U.U..?U.U.?
> > 10: 70 00 00 00 00 90 00 00 00 55 1c XX XX XX XX 00 p....?...U?XXXX.
> > 20: 55 0a 70 XX XX 0f XX XX XX XX XX XX XX XX XX XX U?pXX?XXXXXXXXXX
> > 30: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > 40: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > 50: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > 60: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > 70: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > 80: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > 90: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > a0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > b0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > c0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > d0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > e0: XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XX XXXXXXXXXXXXXXXX
> > f0: XX XX XX XX XX XX XX XX XX XX XX XX 00 35 55 35 XXXXXXXXXXXX.5U5
> >
> > # i2cget -y 1 0x4c 0xff b
> > 0x35
>
> That makes sense for a chip named TMP435. Looks like TI forgot to
> update the value when copying the datasheet from TMP431 to TMP435.
>
Guess so.

I'll make the necessary updates to sensors-detect and the web page.

> Thanks for the dump, by the way :)
>

Same here .. that also helps for writing module test scripts.

Thanks,
Guenter


\
 
 \ /
  Last update: 2014-12-04 20:21    [W:0.047 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site