Messages in this thread | | | Date | Thu, 4 Dec 2014 19:40:46 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec |
| |
> If you don't read all the below, my belief is that we should simply > rename the strings in Addy's patch. We should change "rise-ns" to > "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time". > Wolfram: can you confirm this is OK? I'm voting to leave the "-ns" > off the end of both to avoid asymmetry.
New binding should have the "-ns" suffix, right? So, I'd vote to add the suffix to the new bindings and deprecate the ones used in the designware driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns"
It might be a little more work now, but it will help us in the future, because it is the correct way to do it. [unhandled content-type:application/pgp-signature]
| |