Messages in this thread | | | Date | Thu, 4 Dec 2014 18:56:02 +0100 | From | Radim Krčmář <> | Subject | Re: [PATCH 2/9] KVM: x86: support XSAVES usage in the host |
| |
2014-12-04 16:57+0100, Paolo Bonzini: > Userspace is expecting non-compacted format for KVM_GET_XSAVE, but > struct xsave_struct might be using the compacted format. Convert > in order to preserve userspace ABI. > > Likewise, userspace is passing non-compacted format for KVM_SET_XSAVE > but the kernel will pass it to XRSTORS, and we need to convert back. > > Fixes: f31a9f7c71691569359fa7fb8b0acaa44bce0324 > Cc: Fenghua Yu <fenghua.yu@intel.com> > Cc: stable@vger.kernel.org > Cc: H. Peter Anvin <hpa@linux.intel.com> > Reported-by: Nadav Amit <namit@cs.technion.ac.il> > Tested-by: Nadav Amit <namit@cs.technion.ac.il> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > ---
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
> +++ b/arch/x86/kvm/x86.c > @@ -3132,15 +3132,89 @@ static int kvm_vcpu_ioctl_x86_set_debugregs(struct kvm_vcpu *vcpu, > + u64 xstate_bv = xsave->xsave_hdr.xstate_bv;
(This looks like the only change since last review.)
| |