Messages in this thread | | | Date | Thu, 4 Dec 2014 18:46:42 +0100 | From | Wolfram Sang <> | Subject | Re: [alsa-devel] [RFC 2/2] sound: ppc: keywest: drop using attach adapter |
| |
> > + > > + /* We assume Macs have consecutive I2C bus numbers starting at 0 */ > > + while (adap) { > > + err = keywest_attach_adapter(adap); > > + if (!err) > > + break; > > + i2c_put_adapter(adap); > > + adap = i2c_get_adapter(++i); > > + } > > + > > return 0; > > What if adap is NULL in the last while loop? Isn't it supposed to > return an error?
True, we probably should have something like
return adap ? 0 : -ENODEV;
Thanks! [unhandled content-type:application/pgp-signature]
| |