lkml.org 
[lkml]   [2014]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] video: fbdev-LCDC: Deletion of an unnecessary check before the function call "vfree"
    Hi,

    On 22/11/14 18:00, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sat, 22 Nov 2014 16:51:31 +0100
    >
    > The vfree() function performs also input parameter validation.
    > Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/video/fbdev/sh_mobile_lcdcfb.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
    > index 2bcc84a..cfde21d 100644
    > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
    > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
    > @@ -2181,8 +2181,7 @@ sh_mobile_lcdc_channel_fb_cleanup(struct sh_mobile_lcdc_chan *ch)
    > if (!info || !info->device)
    > return;
    >
    > - if (ch->sglist)
    > - vfree(ch->sglist);
    > + vfree(ch->sglist);
    >
    > fb_dealloc_cmap(&info->cmap);
    > framebuffer_release(info);

    Thanks, I've applied the fbdev patches. Next time, please use
    git-format-patch and git-send-email to send a proper patch series.

    Tomi


    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-12-04 16:01    [W:4.019 / U:0.716 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site