Messages in this thread | | | Date | Wed, 3 Dec 2014 01:22:38 -0800 | From | Darren Hart <> | Subject | Re: [PATCH 1/2] toshiba_acpi: Move hotkey enabling code to own function |
| |
On Tue, Dec 02, 2014 at 10:36:31PM -0700, Azael Avalos wrote: > The hotkey enabling code is being used by > *_setup_keyboard and also by *_resume. > > This patch creates a new function called > toshiba_acpi_enable_hotkeys to be used by > these two functions to avoid duplicating > code.
42 is a little bit narrow, even for us kernel types :-) 72 characters wide is fine.
Patch is fine, but since I had some questions on your others, please correct in V2.
Thanks,
-- Darren Hart Intel Open Source Technology Center
| |