Messages in this thread | | | Date | Thu, 04 Dec 2014 19:06:37 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v2] ftracetests: Add test to test event filter logic |
| |
Hi Steven,
I have just one comment.
(2014/12/04 12:18), Steven Rostedt wrote: > +# Test more complex compares (&& and !!) > +test_cmp2 -ne 0 -a -gt 10 "!= 0" "> 10" "&&" '' > +test_cmp2 -ne 0 -o -gt 10 "!= 0" "> 10" "||" '' > + > +test_cmp2 -ne 0 -a -gt 10 "!= 0" "> 10" "&&" '!' > +test_cmp2 -ne 0 -o -gt 10 "!= 0" "> 10" "||" '!'
These are not fixed :(
> + filter1=$6 > + filter2=$7 > + fconj=$8
are better to be
> + filter1=$6 > + fconj=$7 > + filter2=$8
so that we can easily review parameters.
Others are OK for me.
Thank you,
-- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |