Messages in this thread | | | Date | Wed, 31 Dec 2014 09:55:19 +0100 | From | Jonas Lundqvist <> | Subject | Re: [PATCH] drm: Move two seq_printf's outside of locked mutex |
| |
Hi Jeremiah,
On 12/30/2014 11:52 PM, Jeremiah Mahler wrote: > You changed 'i' but you didn't explain in your log message why you did this.
I can change the commit message to something more generic. "Move code outside of locked mutex" or similar.
> Does this change really improve anything? It may work the same with the > locks moved around. But if you look at the function as a whole, the > locks encapsulate the body of this function nicely. I like the original > design better.
The locking was already done this way, ie after the seq_printf, in the functions drm_clients_info() and drm_gem_name_info() in thr same file. So this change is really more of an alignment.
Best regards Jonas
[unhandled content-type:application/pgp-signature] | |