Messages in this thread Patch in this message | | | Date | Wed, 31 Dec 2014 11:23:01 -0800 | From | Jeremiah Mahler <> | Subject | Re: [PATCH 1/4] staging: rtl8192u: fix comments |
| |
Lorenzo,
On Wed, Dec 31, 2014 at 06:42:53PM +0000, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com> > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 ++++++++++++++++++----------------- > 1 file changed, 432 insertions(+), 409 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c > index 936565d..44f4c38 100644 > --- a/drivers/staging/rtl8192u/r8192U_dm.c > +++ b/drivers/staging/rtl8192u/r8192U_dm.c > @@ -21,14 +21,15 @@ Major Change History: > #include "r8190_rtl8256.h" > #include "r819xU_cmdpkt.h" > /*---------------------------Define Local Constant---------------------------*/ > -// > -// Indicate different AP vendor for IOT issue. > -// > -static u32 edca_setting_DL[HT_IOT_PEER_MAX] = > - { 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0xa44f, 0x5ea44f}; > -static u32 edca_setting_UL[HT_IOT_PEER_MAX] = > - { 0x5e4322, 0xa44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f}; > - > +/* > + * Indicate different AP vendor for IOT issue. > + */ This is OK.
> +static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { > + 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0xa44f, 0x5ea44f > +}; > +static u32 edca_setting_UL[HT_IOT_PEER_MAX] = { > + 0x5e4322, 0xa44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f > +}; But this change is not related to C99 comments and you didn't explain why this change was made in your log message. It should probably be in a separate patch.
[...]
-- - Jeremiah Mahler
| |