lkml.org 
[lkml]   [2014]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup
Bas,

On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote:
> Fixed many checkpatch.pl complaints, ranging from whitespace issues to
> reportedly deprecated function and macro usage.
>
One patch should fix one type of problem. This needs to be broken up
in to individual patches.

> I have not been able to test the code as I do not have access to the
> hardware but since no new features were really added I don't think that
> should pose a problem.
>
> There are still some checkpatch complaints, particularly concerning
> potentially unnecessary 'out of memory' messages. I will provide patches
> for these complaints when I figure out the reason behind it and what to
> do about it.
>
> NOTE: This is my first patch (ever). I have attempted to follow all
> guidelines provided, but I probably will have missed some. If you have
> any comments regarding the quality of this patch or suggestions as to
> what I could do better in the future, please let me know.
>
You are ambitious. I would suggest trying a smaller patch first to
make sure you are doing everything right.

> Signed-off-by: Bas Peters <baspeters93@gmail.com>
> ---
> drivers/isdn/gigaset/asyncdata.c | 9 +++--
> drivers/isdn/gigaset/bas-gigaset.c | 80 ++++++++++++++++++++------------------
> drivers/isdn/gigaset/capi.c | 5 ++-
> drivers/isdn/gigaset/common.c | 8 ++--
> drivers/isdn/gigaset/ev-layer.c | 38 +++++++++++-------
> drivers/isdn/gigaset/gigaset.h | 4 +-
> drivers/isdn/gigaset/i4l.c | 12 +++---
> drivers/isdn/gigaset/interface.c | 10 ++---
> drivers/isdn/gigaset/isocdata.c | 3 ++
> drivers/isdn/gigaset/proc.c | 17 +++++---
> drivers/isdn/gigaset/usb-gigaset.c | 46 +++++++++++++++-------
> 11 files changed, 141 insertions(+), 91 deletions(-)
>
> diff --git a/drivers/isdn/gigaset/asyncdata.c b/drivers/isdn/gigaset/asyncdata.c
[...]

--
- Jeremiah Mahler


\
 
 \ /
  Last update: 2014-12-31 19:01    [W:0.081 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site