Messages in this thread | | | Date | Wed, 31 Dec 2014 18:47:21 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions |
| |
At Wed, 31 Dec 2014 18:07:36 +0100, Rickard Strandqvist wrote: > > 2014-12-31 17:45 GMT+01:00 Takashi Iwai <tiwai@suse.de>: > > > At Wed, 31 Dec 2014 17:41:33 +0100, > > Rickard Strandqvist wrote: > > > > > > 2014-12-31 17:07 GMT+01:00 Takashi Iwai <tiwai@suse.de>: > > > > > > > At Wed, 31 Dec 2014 16:17:02 +0100, > > > > Rickard Strandqvist wrote: > > > > > > > > > > Removes some functions that are not used anywhere: > > > > > > > > See Eliot's previous reply. There will be some code changes, so this > > > > action is no-go as of now. > > > > > > > > > > > > thanks, > > > > > > > > Takashi > > > > > > > > > > > > > Hi Takashi > > > > > > I have restored the function hpi_adapter_set_property() that Eliot > > wanted. > > > And I also have diff the files against the linux-next, but that there are > > > some notable differences. > > > > > > What is it you do not like about my current patch? > > > > More code changes may land in near future, so removing functions isn't > > good at all at this moment. We need to wait until the all things are > > settled down. IOW, forget about this for a while :) > > > > And please add Eliot to Cc at the next time. > > > > > > thanks, > > > > Takashi > > > > > + Eliot > > Hi > > Strange, because I ask specifically if it was just one function Eliot objected > to, and I therefore could resend the patch.
In general, it's bad to do a task like this kind of cleanups during the code change is planned in future. There is more risk than gain in such a case.
You can do it for the really stalling development codes, of course.
Takashi
| |