Messages in this thread | | | Date | Tue, 30 Dec 2014 19:04:35 -0800 | From | Serguey Parkhomovsky <> | Subject | Re: [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration |
| |
On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote: > > If you look at the source code just below these functions you will find: > > EXPORT_SYMBOL(libcfs_arch_init); > EXPORT_SYMBOL(libcfs_arch_cleanup); > > So making these static is incorrect because they are being used outside > of this file. >
Thanks for the review, and sorry about the noise; I'll be more careful next time.
Serguey
| |