Messages in this thread | | | Date | Sun, 28 Dec 2014 17:30:58 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 7/8] locking: Use [READ,ASSIGN]_ONCE() for non-scalar types |
| |
On Sun, Dec 28, 2014 at 01:11:22AM -0800, Davidlohr Bueso wrote: > I guess everyone will eventually have to update, so lets > do our part... and become the first users of ASSIGN_ONCE().
> - ACCESS_ONCE(prev->next) = node; > + ASSIGN_ONCE(node, prev->next);
> - struct mcs_spinlock *next = ACCESS_ONCE(node->next); > + struct mcs_spinlock *next = READ_ONCE(node->next);
That's disgusting and sad, doubly so because I was entirely unaware of that stuff.
| |