Messages in this thread | | | Date | Fri, 26 Dec 2014 22:26:03 +0100 | Subject | Re: [PATCH v2] bcma: Fix three coding style issues, more than 80 characters per line | From | Rafał Miłecki <> |
| |
On 26 December 2014 at 19:33, Oscar Forner Martinez <oscar.forner.martinez@gmail.com> wrote: > - /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP clock */ > + /* 4706 CC and PMU watchdogs are clocked > + * at 1/4 of ALP clock > + */
Your editor seems to be treating tabs incorrectly. Like more than 8 chars. After your patch "clocked" ends after 64 chars. You should try to use up to 80 chars.
> - bcma_err(cc->core->bus, "serial not supported on this device ccrev: 0x%x\n", ccrev); > + bcma_err(cc->core->bus, > + "serial not supported on this device ccrev: 0x%x\n", > + ccrev);
I think you ignored my comment to V1, see it again please ;) It was about putting pointer and string in one line.
-- Rafał
| |