lkml.org 
[lkml]   [2014]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] irqchip: Conexant CX92755 interrupts controller driver
Hi Arnd,

On Tue, Dec 23, 2014 at 10:02:18PM +0100, Arnd Bergmann wrote:
> On Tuesday 23 December 2014 09:58:42 Baruch Siach wrote:
> > +static void __exception_irq_entry digicolor_handle_irq(struct pt_regs *regs)
> > +{
> > + u32 status, hwirq;
> > +
> > + do {
> > + status = readl(digicolor_irq_base + IC_INT0STATUS_LO);
> > + if (status) {
> > + hwirq = ffs(status) - 1;
> > + } else {
> > + status = readl(digicolor_irq_base + IC_INT0STATUS_XLO);
> > + if (status)
> > + hwirq = ffs(status) - 1 + 32;
> > + else
> > + return;
> > + }
> > +
> > + handle_domain_irq(digicolor_irq_domain, hwirq, regs);
> > + } while (1);
> > +}
> >
>
> Have you tried using the generic_irqchip code for this? The hardware
> seems simple enough.

Thanks for the tip. I'll look into converting to GENERIC_IRQ_CHIP for next
version.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


\
 
 \ /
  Last update: 2014-12-24 07:21    [W:0.094 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site