lkml.org 
[lkml]   [2014]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.
From
On 24 December 2014 at 00:55, Oscar Forner Martinez
<oscar.forner.martinez@gmail.com> wrote:
> Three lines with more than 80 characters per line have been split in several lines.
>
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>
> ---
> drivers/bcma/driver_chipcommon.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bcma/driver_chipcommon.c b/drivers/bcma/driver_chipcommon.c
> index 19f6796..1956918 100644
> --- a/drivers/bcma/driver_chipcommon.c
> +++ b/drivers/bcma/driver_chipcommon.c
> @@ -79,7 +79,8 @@ static int bcma_chipco_watchdog_ticks_per_ms(struct bcma_drv_cc *cc)
>
> if (cc->capabilities & BCMA_CC_CAP_PMU) {
> if (bus->chipinfo.id == BCMA_CHIP_ID_BCM4706)
> - /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP clock */
> + /* 4706 CC and PMU watchdogs are clocked */
> + /* at 1/4 of ALP clock */

I don't think we use comments like this. Use normal multiline comment,
also see which one is preferred for that tree.


> - bcma_err(cc->core->bus, "serial not supported on this device ccrev: 0x%x\n", ccrev);
> + bcma_err(cc->core->bus,
> + "serial not supported on this device ccrev: 0x%x\n",
> + ccrev);

I think some subsystems agreed to keep dev/bus pointed and string in
the one line. It makes more sense for me too.


\
 
 \ /
  Last update: 2014-12-24 01:21    [W:0.048 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site