lkml.org 
[lkml]   [2014]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 06/17] net2280: Remove restart_dma inline function definition
Hello Felipe

I was waiting for more comments for the other patches and I forgot to
resend this patch.

I am on holidays and without access to a computer with the right
tools, nevertheless , since the changes are only on the commit message
I have modified the patch with vi.

I have been very careful, but I cannot try to apply it. If it does not
work, please feel free to modify it yourself (if you want) or wait
until I am back


Thanks!!!

On Tue, Dec 23, 2014 at 7:44 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Fri, Nov 28, 2014 at 11:16:16PM +0300, Sergei Shtylyov wrote:
>> On 11/28/2014 06:21 PM, Ricardo Ribalda Delgado wrote:
>>
>> >Thanks for reviewing. I will fix it and resend it on the next version
>> >of the patchset to avoid spamming the ML
>>
>> >I guess it is ok to add your Reviewed-by
>>
>> Yes, if you like.
>>
>> >Thanks!
>>
>> Not at all. :-)
>>
>> [...]
>>
>> >>On 11/28/2014 04:50 PM, Ricardo Ribalda Delgado wrote:
>>
>> >>>restart_dma is not used before it is declaration. Therefore we can
>>
>> >> s/it is/its/.
>>
>> Also s/declaration/definition/.
>>
>> >>>remove this definition.
>>
>> >> You're removing the declaration, not definition.
>
> do I get a new version of this patch ?
>
> --
> balbi



--
Ricardo Ribalda


\
 
 \ /
  Last update: 2014-12-23 22:01    [W:0.074 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site