Messages in this thread | | | Date | Tue, 23 Dec 2014 10:28:26 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] tools: lib: traceevent: event-parse.c: Remove some unused functions |
| |
Em Tue, Dec 23, 2014 at 12:14:50PM +0900, Namhyung Kim escreveu: > Hi Arnaldo and Rickard, > > On Mon, Dec 22, 2014 at 12:52:10PM -0200, Arnaldo Carvalho de Melo wrote: > > Em Sat, Dec 20, 2014 at 01:45:41PM +0100, Rickard Strandqvist escreveu: > > > Removes some functions that are not used anywhere: > > > pevent_get_any_field_val() pevent_get_common_field_val() pevent_event_fields() pevent_event_common_fields() pevent_list_events() pevent_print_event() pevent_data_event_from_type() pevent_register_trace_clock() pevent_pid_is_registered() > > > > > > This was partially found by using a static code analysis program called cppcheck. > > > > Steven, Namhyung, Jiri: > > > > Are you ok with me applying this patch? I'm all for it, dead code better > > be removed, but I don't know what are your plans wrt synchronization > > with the trace-cmd repo. > > They're used by trace-cmd.. Currently Steve backports changes in > libtraceevent to trace-cmd repo occasionally but it eventually will be > a generic standalone library so I'd like to keep the APIs.
So there are plans to use them in the near future, ok.
- Arnaldo
| |