Messages in this thread | | | Subject | Re: [PATCH] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive | From | Joe Perches <> | Date | Tue, 23 Dec 2014 05:14:26 -0800 |
| |
On Tue, 2014-12-23 at 14:02 +0100, Paolo Bonzini wrote: > KERN_<LEVEL> is never redundant with printk_ratelimited. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -4545,7 +4545,7 @@ sub process { > } > > # check for logging functions with KERN_<LEVEL> > - if ($line !~ /printk\s*\(/ && > + if ($line !~ /printk(?:_ratelimited)?\s*\(/ &&
Seems sensible bu this should probably add _once too
if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
Please add and resubmit cc'ing Andrew Morton too.
| |