lkml.org 
[lkml]   [2014]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bluetooth: Add hci_h4p driver
Hi!

> > + /* We should always send word aligned data to h4+ devices */
> > + if (skb->len % 2) {
> > + err = skb_pad(skb, 1);
> > + if (!err)
> > + *skb_put(skb, 1) = 0x00;
> > + }
> > + if (err)
> > + return err;
>
> This is crazy code.
>
> if (skb->len % 2) {
> if (!skb_pad(skb, 1)
> return -ENOMEM;
> *skb_put(skb, 1) = 0x00;
> }

This does not work, it needs to be if (skb_pad())... and it does not
propagate error value. Took me few boots to debug, as I still can't
scroll back after kernel crash...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-12-23 13:41    [W:0.283 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site