Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH RFC] ipw2200: select CFG80211_WEXT | Date | Tue, 23 Dec 2014 12:50:54 +0200 |
| |
Paul Bolle <pebolle@tiscali.nl> writes:
> On Tue, 2014-12-23 at 08:52 +0200, Kalle Valo wrote: >> Paul Bolle <pebolle@tiscali.nl> writes: >> >> > Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") >> > made it impossible to depend on CFG80211_WEXT. It does still allow to >> > select that symbol. (Yes, the commit summary is confusing.) >> > >> > So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be >> > built again. >> >> I think the last sentence is a bit misleading (this isn't a compilation >> error, right?) > > No, it's not a compilation error. > > The reasoning here is that all code hidden behind a Kconfig symbol that > cannot be set will, in practice, never be built. Sure, there are hoops > one can jump through to try to bypass the generated .config, but no one > should have to do that. > >> and I would like to clarify it like this: >> >> "So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be >> enabled in config again." >> >> Does that look ok? > > I understand the confusion my text might cause, so I'm fine with your > amendment.
Thanks for checking. I'll modify the commit log and apply it to wireless-drivers.git.
-- Kalle Valo
| |