Messages in this thread | | | Date | Mon, 22 Dec 2014 09:36:06 -0800 | From | Nathan Whitehorn <> | Subject | Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function |
| |
On 12/22/14 09:26, Geoff Levand wrote: > On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: >> Remove the function ps3_repository_write_highmem_info() that is not used anywhere. > NAK > > ps3_repository_write_highmem_info() is needed by otheros++. What we > need is a kernel patch to add the highmem info to the repository once it > is known. > > These ps3_repository_write_highmem routines are also the only > documentation the freeBSD port has as to how the highmem info is (should > be) saved in the repository. > > -Geoff > >
Yes, we really need this for FreeBSD since that port uses the repository directly instead of FDT. Thanks for noticing this. We could adapt FreeBSD to use FDT (this is the only non-device-tree PowerPC port), but there hasn't been any reason to do that thus far given the availability of the repository information. -Nathan
| |