Messages in this thread | | | Date | Mon, 22 Dec 2014 22:23:41 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH v5 3/8] crypto: AF_ALG: add AEAD support |
| |
On Sun, Dec 07, 2014 at 11:22:30PM +0100, Stephan Mueller wrote: > > +static inline bool aead_sufficient_data(struct aead_ctx *ctx) > +{ > + unsigned as = crypto_aead_authsize(crypto_aead_reqtfm(&ctx->aead_req)); > + > + return (ctx->used >= (ctx->aead_assoclen + ctx->enc ? : as ));
Is this supposed to be
return (ctx->used >= (ctx->aead_assoclen + (ctx->enc ?: as)));
> +static int aead_recvmsg(struct kiocb *unused, struct socket *sock, > + struct msghdr *msg, size_t ignored, int flags) > +{
...
> + err = -ENOMEM; > + if (!aead_sufficient_data(ctx)) > + goto unlock;
You should just block if there is insufficient input.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |