Messages in this thread | | | Date | Sun, 21 Dec 2014 18:00:39 -0800 | From | Greg KH <> | Subject | Re: [PATCH 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of pr_err insted of printk |
| |
On Mon, Dec 22, 2014 at 02:17:30AM +0100, Simone Weiss wrote: > > Signed-off-by: Simone Weiss <simone.weiss@fau.de> > Signed-off-by: Helene Gsaenger <helene.gsaenger@studium.fau.de> > --- > drivers/staging/dgnc/dgnc_sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c > index 2fd34ca..0fa2388 100644 > --- a/drivers/staging/dgnc/dgnc_sysfs.c > +++ b/drivers/staging/dgnc/dgnc_sysfs.c > @@ -91,7 +91,7 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver) > rc |= driver_create_file(driverfs, &driver_attr_maxboards); > rc |= driver_create_file(driverfs, &driver_attr_pollrate); > if (rc) > - printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n"); > + pr_err("DGNC: sysfs driver_create_file failed!\n");
No, use dev_err(), as you have access to a struct device.
thanks,
greg k-h
| |