Messages in this thread | | | Date | Sun, 21 Dec 2014 10:02:49 -0800 | From | Dave Hansen <> | Subject | Re: [PATCH] proc: task_mmu: show page size in /proc/<pid>/numa_maps |
| |
On 12/20/2014 11:44 AM, Rafael Aquini wrote: >> > >> > It would be simpler to include this unconditionally. Otherwise you >> > are forcing everybody parsing the file and trying to run calculations >> > of it to check for its presence, and then have them fall back and get >> > the value from somewhere else if not. > I'm fine either way, it makes the change even simpler. Also, if we > decide to get rid of page_size != PAGE_SIZE condition I believe we can > also get rid of that "huge" hint being conditionally printed out too.
That would break existing users of the "huge" flag. That makes it out of the question, right?
| |