Messages in this thread | | | Subject | Re: [PATCH] checkpatch: add check for keyword 'boolean' in Kconfig definitions | From | Joe Perches <> | Date | Sat, 20 Dec 2014 12:49:37 -0800 |
| |
(adding Andrew Morton)
On Sat, 2014-12-20 at 15:40 -0500, Christoph Jaeger wrote: > Discourage the use of keyword 'boolean' for type definition attributes of > config options as support for it will be dropped later on. > > Reference: http://lkml.kernel.org/r/cover.1418003065.git.cj@linux.com > Suggested-by: Daniel Borkmann <dborkman@redhat.com> > Signed-off-by: Christoph Jaeger <cj@linux.com>
Seems sensible.
> --- > scripts/checkpatch.pl | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index f0bb6d6..cae974e 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2355,6 +2355,13 @@ sub process { > "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n"); > } > > +# discourage the use of boolean for type definition attributes of Kconfig options > + if ($realfile =~ /Kconfig/ && > + $line =~ /^\+\s*\bboolean\b/) { > + WARN("CONFIG_TYPE_BOOLEAN", > + "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); > + } > + > if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && > ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { > my $flag = $1;
| |