lkml.org 
[lkml]   [2014]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v8 08/50] virtio: memory access APIs
    Hi Michael,

    Thanks for the patch.

    On Mon, Dec 1, 2014 at 4:03 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
    > virtio 1.0 makes all memory structures LE, so
    [Snip]
    > +/*
    > + * Low-level memory accessors for handling virtio in modern little endian and in
    > + * compatibility native endian format.
    > + */
    > +
    > +static inline u16 __virtio16_to_cpu(bool little_endian, __virtio16 val)
    > +{
    > + if (little_endian)
    > + return le16_to_cpu((__force __le16)val);
    > + else
    > + return (__force u16)val;
    > +}
    > +
    > +static inline __virtio16 __cpu_to_virtio16(bool little_endian, u16 val)
    > +{
    > + if (little_endian)
    > + return (__force __virtio16)cpu_to_le16(val);
    > + else
    > + return (__force __virtio16)val;
    > +}
    > +
    > +static inline u32 __virtio32_to_cpu(bool little_endian, __virtio32 val)
    > +{
    > + if (little_endian)
    > + return le32_to_cpu((__force __le32)val);
    > + else
    > + return (__force u32)val;
    > +}
    > +
    > +static inline __virtio32 __cpu_to_virtio32(bool little_endian, u32 val)
    > +{
    > + if (little_endian)
    > + return (__force __virtio32)cpu_to_le32(val);
    > + else
    > + return (__force __virtio32)val;
    > +}
    > +
    > +static inline u64 __virtio64_to_cpu(bool little_endian, __virtio64 val)
    > +{
    > + if (little_endian)
    > + return le64_to_cpu((__force __le64)val);
    > + else
    > + return (__force u64)val;
    > +}
    > +
    > +static inline __virtio64 __cpu_to_virtio64(bool little_endian, u64 val)
    > +{
    > + if (little_endian)
    > + return (__force __virtio64)cpu_to_le64(val);
    > + else
    > + return (__force __virtio64)val;
    > +}
    > +

    Nitpicking, could remove the else for the all above functions and
    align the return appropriately ?

    Apart from that patch looks good.

    Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

    Thanks,
    --Prabhakar Lad


    \
     
     \ /
      Last update: 2014-12-03 02:21    [W:6.903 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site