Messages in this thread | | | Date | Tue, 2 Dec 2014 09:47:18 -0800 | Subject | Re: [PATCH v2] mmc: dw_mmc: add quirk for broken data transfer over scheme | From | Doug Anderson <> |
| |
Addy,
On Mon, Dec 1, 2014 at 11:50 PM, addy ke <addy.ke@rock-chips.com> wrote: > We don't know why we have this problem, > but this problem is really exist, and we need patch to fix this problem now. > I will post a follow up change when we find the root cause.
To me that seems reasonable. Certainly I would prefer to have this patch while waiting for the root cause, but it's up to Ulf.
> And there is a little probability of this problem on RK SoC, such as RK3188, RK3066, > when worse card inserted in. > Maybe the other SoCs have the similar problem. > > So I will add this quirk in rockchip code(dw_mmc-rockchip.c) as follows: > static int dw_mci_rockchip_parse_dt(struct dw_mci *host) > { > host->quirk |= DW_MCI_QUIRK_BROKEN_DTO; > > return 0; > } > > ...... > .parse_dt = dw_mci_rockchip_parse_dt, > ...... > > is right?
When you added "sdio_id0" you got feedback that you should use dw_mci_rockchip_init(). Why not do the same thing here?
| |