This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Thu May 2 15:31:20 2024 >From spaans Fri Dec 19 09:25:12 2014 Received: from pop.ziggo.nl [212.54.42.19] by squeeze.vs19.net with POP3 (fetchmail-6.3.21) for (single-drop); Fri, 19 Dec 2014 09:25:12 +0100 (CET) Received: from md5.tb.mail.iss.local ([212.54.42.143]) by mc5.tb.mail.iss.local (Dovecot) with LMTP id RYsgJczfk1RaAwAAh0Kp1A for ; Fri, 19 Dec 2014 09:22:13 +0100 Received: from mx16.tb.mail.iss.as9143.net ([212.54.42.143]) by md5.tb.mail.iss.local (Dovecot) with LMTP id WdLsQiPSF1QBBAAA7jSZHA ; Fri, 19 Dec 2014 09:23:57 +0100 Received: from vger.kernel.org ([209.132.180.67]) by mx16.tb.mail.iss.as9143.net with esmtp (Exim 4.82) (envelope-from ) id 1Y1spA-0003U5-Ca for bmw12-lkml@ziggo.nl; Fri, 19 Dec 2014 09:22:13 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbaLSIWB (ORCPT ); Fri, 19 Dec 2014 03:22:01 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:12765 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373AbaLSIV7 (ORCPT ); Fri, 19 Dec 2014 03:21:59 -0500 Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NGT00M9TLWFTP90@mailout2.samsung.com>; Fri, 19 Dec Received: from epcpsbgm1.samsung.com ( [172.20.52.112]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id CF.CF.18167.E10E3945; Fri, 19 Dec 2014 17:21:50 +0900 (KST) X-AuditID: cbfee690-f79ab6d0000046f7-1f-5493e01eba1f Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 8E.5A.20081.E10E3945; Fri, 19 Dec 2014 17:21:50 +0900 (KST) Content-Transfer-Encoding: 8BIT Received: from [10.252.82.199] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NGT00ISRLWE9S50@mmp2.samsung.com>; Fri, 19 Dec 2014 17:21:50 +0900 (KST) Message-Id: <5493E01E.6090806@samsung.com> Date: Fri, 19 Dec 2014 17:21:50 +0900 From: jonghwa3.lee@samsung.com User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 To: myungjoo.ham@samsung.com Cc: =?UTF-8?B?7J207KKF7ZmU?= , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "sre@kernel.org" , "dbaryshkov@gmail.com" , " Subject: Re: [PATCH RESEND v2 02/10] power: charger-manager: Use power_supply_changed() not private uevent. References: <1443120167.38671418974875751.JavaMail.weblogic@epmlwas08d> In-Reply-To: <1443120167.38671418974875751.JavaMail.weblogic@epmlwas08d> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsWyRsSkQFfuweQQg/mfzS0ObtW0uP7lOavF pCfvmS0mrpzMbNF59gmzxeVdc9gsPvceYbS43biCzeLuqaNsFqd3lzhweUzo/8TosXPWXXaP zSu0PDat6mTz6NuyitFjxerv7B6fN8kFsEdx2aSk5mSWpRbp2yVwZTx5/5KloEGg4sj/QywN jBN5uxg5OSQETCRWbv3MDGGLSVy4t56ti5G X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42I5/e+xoK7cg8khBt239S0ObtW0uP7lOavF pCfvmS0mrpzMbNF59gmzxeVdc9gsPvceYbS43biCzeLuqaNsFqd3lzhweUzo/8TosXPWXXaP zSu0PDat6mTz6NuyitFjxerv7B6fN8kFsEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZ GOoaWlqYKynkJeam2iq5+AToumXmAF2npFC DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-Ziggo-spamsetting: Instelling=Gemiddeld Scorelimiet=14 X-Ziggo-spambar: ++ X-Ziggo-spamscore: 2.1 X-Ziggo-spamreport: CM_META_TB_NOARR=0.5,CM_SPACED_DATE=0.5,HEADER_FROM_DIFFERENT_DOMAINS=0.001,L_TAB_IN_FROM=2,NO_REAL_NAME=0.1,RCVD_IN_JMF_W=-1,RCVD_IN_MSPIKE_H3=-0.01,RCVD_IN_MSPIKE_WL=-0.01,T_RP_MATCHES_RCVD=-0.01 X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No On 2014년 12월 19일 16:41, MyungJoo Ham wrote: >> >> Whenever battery status is changed, charger manager tries to trigger uevent >> through private interface. This patch modifies it to use power_supply_changed() >> since it belongs to power supply subsystem. >> >> Signed-off-by: Jonghwa Lee > > The original uevent_notify() has two additional mechanisms: > C1. Save events in suspend-again context and show them up at wakeup. > C2. If the new event is a duplicated event, ignore it. > > Questions: > Q1. Have you checked if C1 is met with the modification? Besides, have > you made it sure that the modification won't change the behavior of > suspend-again context? (whether "theoretical" or "experimental") It won't ruin suspend-again context because it just changes the location where the charger manager's notice to go. > Q2. Do you still support C2? > For example, if we have notifited the user that we are charging > 30 seconds ago, we should never bother the user with another message > that declares that it is charging unless we have notified that > we are not charging since then. > Above case never happens. If charging state is not changed, the report will not be triggered. Maybe current driver will send same event repeatedly even though, these patch series will guarantee not to do so. And also if we have a status changing while short time wake-up which expects suspend-again proceeds in near future, I think it is better to notify it to the user not to keep until undetermined 'TRUE' wake-up. Thanks, Jonghwa > Cheers, > MyungJoo. > >> --- >> drivers/power/charger-manager.c | 91 +++++---------------------------------- >> 1 file changed, 11 insertions(+), 80 deletions(-) >> > N�����r��y���b�X��ǧv�^�)޺{.n�+����{��h����ܨ}���Ơz�&j:+v�������zZ+��+zf���h���~����i���z��w���?����&�)ߢfl=== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/