lkml.org 
[lkml]   [2014]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] mtd: test: Replace timeval with ktime_t in speedtest.c and torturetest.c
Date
On Thursday 18 December 2014 11:23:31 Chunyan Zhang wrote:
> This patch changes the 32-bit time type (timeval) to the 64-bit one
> (ktime_t), since 32-bit time types will break in the year 2038.
>
> I use ktime_t instead of timeval to define 'start' and 'finish'
> which are used to get the time for tow points.
>
> This patch also changes do_gettimeofday() to ktime_get() accordingly,
> since ktime_get returns a ktime_t, but do_gettimeofday returns a
> struct timeval, and the other reason is that ktime_get() uses
> the monotonic clock.
>
> This patch is based on another patch which privides a millisecond
> time difference function 'ktime_ms_delta' in ktime.h
>
> http://lkml.iu.edu//hypermail/linux/kernel/1412.2/00625.html
>
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>

The new version still looks good to me, but as there is now a
dependency on another patch, I'd suggest we queue this up in the
y2038 branch together with the patch that introduces ktime_ms_delta.

David or Brian, can you provide an Ack for this, or do you have
any objections?

Arnd


\
 
 \ /
  Last update: 2014-12-18 09:21    [W:0.051 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site