lkml.org 
[lkml]   [2014]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness
From
Date
Hi Kyle,

On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote:
> scripts/headers_install.sh will transform __packed to
> __attribute__((packed)), so the #ifndef is not necessary.
> (and, in fact, it's problematic, because we'll end up with the header
> containing:
> #ifndef __attribute__((packed))
> #define __attribu...
> and so forth.)
>
> Cc: stable@vger.kernel.org # 3.18
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> ---
> cc-ing stable@ so this headers fix gets picked up by distros.
>
> --- a/include/uapi/linux/target_core_user.h
> +++ b/include/uapi/linux/target_core_user.h
> @@ -6,10 +6,6 @@
> #include <linux/types.h>
> #include <linux/uio.h>
>
> -#ifndef __packed
> -#define __packed __attribute__((packed))
> -#endif
> -
> #define TCMU_VERSION "1.0"
>
> /*

Applied to target-pending/for-next.

Thanks!

--nab




\
 
 \ /
  Last update: 2014-12-19 03:01    [W:0.030 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site