Messages in this thread Patch in this message | | | Subject | checkpatch: Emit an error when using predefined timestamp macros | From | Joe Perches <> | Date | Thu, 18 Dec 2014 14:17:08 -0800 |
| |
Since commit fe7c36c7bde1 ("Makefile: Build with -Werror=date-time if the compiler supports it"), use of __DATE__, __TIME__, and __TIMESTAMP__ has not been allowed.
As this test is gcc version specific (> 4.9), it hasn't prevented a few new uses from creeping into the kernel sources.
Make checkpatch complain about them.
Original-patch-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f0bb6d6..501c286 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5089,6 +5089,12 @@ sub process { } } +# check for uses of __DATE__, __TIME__, __TIMESTAMP__ + while ($line =~ /\b(__(?:DATE|TIME|TIMESTAMP)__)\b/g) { + ERROR("DATE_TIME", + "Use of the '$1' macro makes the build non-deterministic\n" . $herecurr); + } + # check for use of yield() if ($line =~ /\byield\s*\(\s*\)/) { WARN("YIELD",
| |