Messages in this thread | | | Date | Thu, 18 Dec 2014 14:59:32 -0600 | From | atull <> | Subject | Re: [PATCH v5 4/6] staging: fpga manager: add driver for socfpga fpga manager |
| |
On Thu, 18 Dec 2014, Michal Simek wrote:
Hi Michal,
> > + > > + /* Write out remaining non 32-bit chunks. */ > > + switch (count) { > > + case 3: > > + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x00ffffff); > > + break; > > + case 2: > > + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x0000ffff); > > + break; > > + case 1: > > + socfpga_fpga_data_writel(priv, buffer_32[i++] & 0x000000ff); > > + break; > > + default: > > + /* This will never happen. */ > > why not just return any error code here even if this can't happen. >
OK. Will be in v6.
> > add it to one line. > > The rest is looks good to me. I think this is good to go in. > > Acked-by: Michal Simek <michal.simek@xilinx.com> > > Thanks, > Michal >
Thanks for the feedback. So patches 1-4 look good now?
For v6 I will leave out patches 5/6 and 6/6.
Alan
| |