lkml.org 
[lkml]   [2014]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] USB: gadget: udc: atmel: change setting for DMA
Le 17/12/2014 10:18, Bo Shen a écrit :
> According to the datasheet, when transfer using DMA, the control
> setting for IN packet only need END_BUF_EN, END_BUF_IE, CH_EN,
> while for OUT packet, need more two bits END_TR_EN and END_TR_IE
> to be configured.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>

Seems okay, even if I am not used to these aspects:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

I would also add a "stable" tag to these patches, something like this:

Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver)
Cc: stable@vger.kernel.org # always been there...


Felipe,

Can you take both of these patches as fixes?

> ---
>
> drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index ce88237..63e90f5 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -716,10 +716,10 @@ static int queue_dma(struct usba_udc *udc, struct usba_ep *ep,
> req->using_dma = 1;
> req->ctrl = USBA_BF(DMA_BUF_LEN, req->req.length)
> | USBA_DMA_CH_EN | USBA_DMA_END_BUF_IE
> - | USBA_DMA_END_TR_EN | USBA_DMA_END_TR_IE;
> + | USBA_DMA_END_BUF_EN;
>
> - if (ep->is_in)
> - req->ctrl |= USBA_DMA_END_BUF_EN;
> + if (!ep->is_in)
> + req->ctrl |= USBA_DMA_END_TR_EN | USBA_DMA_END_TR_IE;
>
> /*
> * Add this request to the queue and submit for DMA if
>


--
Nicolas Ferre


\
 
 \ /
  Last update: 2014-12-18 19:01    [W:0.043 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site