lkml.org 
[lkml]   [2014]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/urgent] x86/tls: Don't validate lm in set_thread_area() after all
On 12/18/2014 03:16 AM, tip-bot for Andy Lutomirski wrote:
> Commit-ID: 3fb2f4237bb452eb4e98f6a5dbd5a445b4fed9d0
> Gitweb: http://git.kernel.org/tip/3fb2f4237bb452eb4e98f6a5dbd5a445b4fed9d0
> Author: Andy Lutomirski <luto@amacapital.net>
> AuthorDate: Wed, 17 Dec 2014 14:48:30 -0800
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 18 Dec 2014 12:12:26 +0100
>
> x86/tls: Don't validate lm in set_thread_area() after all
>
> It turns out that there's a lurking ABI issue. GCC, when
> compiling this in a 32-bit program:
>
> struct user_desc desc = {
> .entry_number = idx,
> .base_addr = base,
> .limit = 0xfffff,
> .seg_32bit = 1,
> .contents = 0, /* Data, grow-up */
> .read_exec_only = 0,
> .limit_in_pages = 1,
> .seg_not_present = 0,
> .useable = 0,
> };
>
> will leave .lm uninitialized. This means that anything in the
> kernel that reads user_desc.lm for 32-bit tasks is unreliable.
>

No, it won't. However, if you initialize this dynamically field by
field rather than as an initializer, then you are correct.

-hpa



\
 
 \ /
  Last update: 2014-12-18 18:41    [W:0.050 / U:2.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site