Messages in this thread | | | Date | Thu, 18 Dec 2014 16:10:20 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH] perf ftrace: Factor regs retrieval for function tracer |
| |
On Thu, Dec 18, 2014 at 03:28:27PM +0100, Jiri Olsa wrote: > > Would not something like: > > > > struct pt_regs *regs; > > > > entry = perf_trace_buf_prepare(ENTRY_SIZE, TRACE_FN, ®s, &rctx); > > if (!pt_regs) { > > perf_fetch_caller_regs(regs); > > pt_regs = regs; > > } > > > > Be simpler? > > well, I wanted to omit touching the '__perf_regs' var > in perf_trace_buf_prepare: > > if (regs) > *regs = this_cpu_ptr(&__perf_regs[*rctxp]);
OK, fair enough I suppose. Thanks!
| |