lkml.org 
[lkml]   [2014]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [f2fs-dev] [PATCH v2] f2fs: use ra_meta_pages to simplify readahead code in restore_node_summary
Date
Hi Changman,

> -----Original Message-----
> From: Changman Lee [mailto:cm224.lee@gmail.com]
> Sent: Wednesday, December 17, 2014 11:20 PM
> To: Chao Yu
> Cc: Jaegeuk Kim; Changman Lee; linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH v2] f2fs: use ra_meta_pages to simplify readahead code in
> restore_node_summary
>
> Hi,
>
> Is there any reason to use truncate_inode_pages_range instead of
> invalidate_mapping_pages?
> IMHO, it seems nice to just use invalidate_mapping_pages because pages
> of meta_inode shouldn't be dirty, locked, under writeback or mapped in
> this function.
> If there is my misunderstanding, let me know.

I think you're right, I use truncate_inode_pages_range because just following the
usage of readahead-invalidate pair in recovery flow, but without considering the
difference between them.

I will fix this as you suggested.

>
> Thanks,
>
> Reviewed-by: Changman Lee <cm224.lee@samsung.com>

And thanks for your review! :)

Regards,
Yu



\
 
 \ /
  Last update: 2014-12-18 11:01    [W:0.043 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site