Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/2] tty: serial: 8250_mtk: Add earlycon | Date | Thu, 18 Dec 2014 10:12:33 +0100 |
| |
On Thursday 18 December 2014 09:48:31 Matthias Brugger wrote: > > +static void __init mtk8250_serial_putc(struct uart_port *port, int c) > > +{ > > + while ((readl(port->membase + (UART_LSR << 2)) & BOTH_EMPTY) != > > + BOTH_EMPTY) > > + ; > > Please delete newline before the semicolon. >
No, that newline is best kept in there for clarity. An even better way to write this would be using cpu_relax():
while ((readl(port->membase + (UART_LSR << 2)) & BOTH_EMPTY) != BOTH_EMPTY) cpu_relax();
which the kernel convention for doing busy-loops.
Arnd
| |