lkml.org 
[lkml]   [2014]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] gpio: pcf857x: Propagate wake-up setting to parent irq controller
On Wed, Dec 10, 2014 at 10:36 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> The pcf857x GPIO and interrupt controller uses dummy_irq_chip, which
> does not implement irq_chip.irq_set_wake() and does not set
> IRQCHIP_SKIP_SET_WAKE.
>
> This causes two s2ram issues if wake-up is enabled for the pcf857x GPIO
> pins:
> 1. During resume from s2ram, the following warning is printed:
>
> WARNING: CPU: 0 PID: 1046 at kernel/irq/manage.c:537 irq_set_irq_wake+0x9c/0xf8()
> Unbalanced IRQ 113 wake disable
>
> 2. Wake-up through the pcf857x GPIO pins may fail, as the parent
> interrupt controller may be suspended.
>
> Migrate the pcf857x GPIO and interrupt controller from dummy_irq_chip to
> its own irq_chip. This irq chip implements irq_chip.irq_set_wake() to
> propagate its wake-up setting to the parent interrupt controller.
>
> This fixes wake-up through gpio-keys on sh73a0/kzm9g, where the pcf857x
> interrupt is cascaded to irq-renesas-intc-irqpin, and the latter must
> not be suspended when wake-up is enabled.

I am not very familiar with the IRQ subsystem, but wouldn't it be
possible (and better) to try and fix/adapt dummy_irq_chip so it
displays the right behavior? At least your first point looks like an
issue with it.


\
 
 \ /
  Last update: 2014-12-17 07:41    [W:0.145 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site