Messages in this thread | | | From | Alexandre Courbot <> | Date | Wed, 17 Dec 2014 17:43:12 +0900 | Subject | Re: [Patch v4 2/2] gpio: Document GPIO hogging mechanism |
| |
A few nits:
On Sat, Dec 13, 2014 at 7:07 AM, Benoit Parrot <bparrot@ti.com> wrote: > Add GPIO hogging documentation to gpio.txt > > Signed-off-by: Benoit Parrot <bparrot@ti.com> > --- > Changes since v3: > * Renamed the "direction" DT properties to "state". > > Documentation/devicetree/bindings/gpio/gpio.txt | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt > index 3fb8f53..a38da91 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio.txt > @@ -103,6 +103,22 @@ Every GPIO controller node must contain both an empty "gpio-controller" > property, and a #gpio-cells integer property, which indicates the number of > cells in a gpio-specifier. > > +The GPIO chip may contain GPIO hog definitions. GPIO hogging is a mechanism > +providing automatic GPIO request and configuration as part of the > +gpio-controller's driver probe function. > + > +Each GPIO hog definition is represented as a child node of the GPIO controller. > +Required properties: > +- gpio-hog: A property specifying that this child node represent a gpio-hog.
... represent a GPIO hog.
> +- gpios: Store the gpio information (id, flags, ...). Shall contain the > + number of cells specified in its parent node (GPIO controller > + node). > +- state: A property specifying the direction/value needed. This property > + can take the folowing values: input, output-high, output-low.
s/folowing/following
This aside,
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
| |