lkml.org 
[lkml]   [2014]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools lib traceevent: Add support for IP address formats
On 12/17/14 9:26 PM, Namhyung Kim wrote:
>
> It'd be better if we do it like below..
>
> char i = *ptr++;
>
> Why not passing ptr + 1 to print_ip_arg()?
>

That parsing loop is a bit weird - and deep. And I only wanted to
consume 'pi' and 'pI' with parse_ip_arg if and only if the next letters
are '4', '6' and 'S'.

David



\
 
 \ /
  Last update: 2014-12-18 06:01    [W:0.047 / U:1.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site